Question: Optimize and analyze the following code (how might you improve this?): public List getPlanets(DataSource d, String galaxy) throws SQLException { Connection c; Statement s; ResultSet
Optimize and analyze the following code (how might you improve this?):
public List getPlanets(DataSource d, String galaxy) throws SQLException { Connection c; Statement s; ResultSet rs; Planet p;
c = d.getConnection(); s = c.createStatement(); rs = s.executeQuery("select * from planets where galaxy = '" + galaxy + "'");
List l = new ArrayList();
while (rs.next()) { p = new Planet();
p.setName(rs.getString("name")); p.setDiameter(rs.getString("diameter")); p.setMass(rs.getString("mass")); l.add(p); }
return l; }
Step by Step Solution
There are 3 Steps involved in it
Get step-by-step solutions from verified subject matter experts
