SQL

Review the following data process and code snippet.

Process: Any file submitted for processing results in the creation of a single package. Files larger than 2 MB are split into smaller, 2 MB or less files. A separate FileID is assigned to each file at the end of the import process.

Example: File A.txt is 3 MB.

During processing, FileA.txt is split into FileA-Part1.txt and FileA-Part2.txt, where FileA-Part1.txt is 2 MB and FileA-Part2.txt is 1 MB.

Code snippet:

INSERT INTO #LoopTable(PkgID,FileID)

SELECT DISTINCT PkgID, FileID FROM Packages

SELECT @i = MIN(PkgID), @j = MAX(PkgID) FROM #LoopTable

WHILE @i <= @j

BEGIN

SELECT @PkgID = PkgID, @FileID = FileID

FROM #LoopTable

WHERE PkgID = @i

-- Do something with data

INSERT INTO #ResultsTable

SELECT *

...

WHERE PkgID = @PkgID

AND FileID = @FileID

SELECT @i = MIN(PkgID) FROM #LoopTable WHERE PkgID > @PkgID

END

Question: Describe in your own words why the code may not provide the correct results. What would you do differently to ensure the correct results every time?